Avoid exceptions when parsing _NormalizedWindowsSdkSupportedTargetPlatformVersion #51134
+7
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| <_NormalizedWindowsSdkSupportedTargetPlatformVersion Include="@(WindowsSdkSupportedTargetPlatformVersion)"> | ||
| <NormalizedSupportedTargetPlatformVersion | ||
| Condition="$([MSBuild]::ValueOrDefault('%(Identity)', '').Split('.').Length) == 4 And | ||
| $([MSBuild]::ValueOrDefault('%(Identity)', '').Split('.').GetValue(3)) == '1'" |
There was a problem hiding this comment.
Unfortunately in the speculative-evaluation path GetValue({}) throws an IndexOutOfRangeException. Thinking of alternatives.
rainersigwald
requested changes
Oct 6, 2025
Comment on lines
+29
to
+31
| Condition="$([MSBuild]::ValueOrDefault('%(Identity)', '').Split('.').Length) == 4 And | ||
| $([MSBuild]::ValueOrDefault('%(Identity)', '').Split('.').GetValue(3)) == '1'" | ||
| >$([MSBuild]::ValueOrDefault('%(Identity)', '').Split('.').GetValue(0)).$([MSBuild]::ValueOrDefault('%(Identity)', '').Split('.').GetValue(1)).$([MSBuild]::ValueOrDefault('%(Identity)', '').Split('.').GetValue(2)).0</NormalizedSupportedTargetPlatformVersion> |
There was a problem hiding this comment.
AFAIK in the debugger this works with no internal exceptions:
Suggested change
| Condition="$([MSBuild]::ValueOrDefault('%(Identity)', '').Split('.').Length) == 4 And | |
| $([MSBuild]::ValueOrDefault('%(Identity)', '').Split('.').GetValue(3)) == '1'" | |
| >$([MSBuild]::ValueOrDefault('%(Identity)', '').Split('.').GetValue(0)).$([MSBuild]::ValueOrDefault('%(Identity)', '').Split('.').GetValue(1)).$([MSBuild]::ValueOrDefault('%(Identity)', '').Split('.').GetValue(2)).0</NormalizedSupportedTargetPlatformVersion> | |
| Condition="$([System.Text.RegularExpressions.Regex]::IsMatch(%(Identity), '^((\d+\.){3})1$'))" | |
| >$([System.Text.RegularExpressions.Regex]::Replace(%(Identity), '^((\d+\.){3})1$', '${1}0'))</NormalizedSupportedTargetPlatformVersion> |
This was referenced Oct 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For "funky" reasons related to dotnet/msbuild#3460, the version normalization that we added in #50264 is causing exceptions to be thrown. This isn't a functional issue, the fact that the exceptions are thrown and then caught are part of how MSBuild works.
However, the additional exceptions are showing up on VS perf tests as a regression in the total number of exceptions thrown.
This PR rewrites the logic to avoid calling Version.Parse on the
%(Identity), which should avoid the exceptions.